fix: Handle dark and light mode with symbolic icon #2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
added
the
PR: Modifications requested
buhtz
added
PR: Waiting for review
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state (update from 2025-11-11)
Icon scaling in XFCE is much more complex than I thought. 🤣
In this screenshot the XFCE Panel is set to 128px self-height. The green numbers are the pixels settings for the icons (in xfce panel) them self. The systray addon in that panel is set to auto-scale the icons (and should adapt the panels icon scaling settings).
This is a more "normal" setup using 32px panel height with auto-scalled icons.
Previous icon version just for comparision